[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG |
Date: |
Wed, 22 Jul 2009 21:40:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Anthony Liguori wrote:
> Jan Kiszka wrote:
>> ----------->
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>>
>> kvm-all.c | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/kvm-all.c b/kvm-all.c
>> index 824bb4c..53925be 100644
>> --- a/kvm-all.c
>> +++ b/kvm-all.c
>> @@ -348,7 +348,9 @@ int
>> kvm_physical_sync_dirty_bitmap(target_phys_addr_t start_addr,
>> d.slot = mem->slot;
>>
>> r = kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d);
>> - if (r == -EINVAL) {
>> + /* KVM for PowerPC returns illicit -ENOTSUPP (-524) which we
>> handle
>> + * below. */
>> + if (r < 0 && r != -524) {
>>
>
> That makes me uncomfortable. Shouldn't we make kvm return something
> that's exposed to userspace?
>
Yes, but we can't do this from user space :) (or in other words: there
are already kernels out there which return this invalid code).
The situation would only be different if Alex said that it takes further
kernel patches anyway to make his PowerPC targets work. Dunno.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] Re: [COMMIT bd83677] Fake dirty loggin when it's not there, Jan Kiszka, 2009/07/22
- Re: [Qemu-devel] Re: [COMMIT bd83677] Fake dirty loggin when it's not there, Anthony Liguori, 2009/07/22
- [Qemu-devel] [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Jan Kiszka, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Anthony Liguori, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG,
Jan Kiszka <=
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Anthony Liguori, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Jan Kiszka, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Alexander Graf, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Jan Kiszka, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Alexander Graf, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Anthony Liguori, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Alexander Graf, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Jan Kiszka, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Anthony Liguori, 2009/07/22
- [Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG, Alexander Graf, 2009/07/22