Re: [Qemu-devel] [PATCH] Check availability of uuid header / lib

[Stefan Weil]

Stefan Weil schrieb:
> The Universally Unique Identifier library will be used
> for the new vdi block driver and maybe other parts of QEMU.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> Makefile | 1 +
> Makefile.target | 2 ++
> configure | 21 +++++++++++++++++++++
> 3 files changed, 24 insertions(+), 0 deletions(-)
...


That patch no longer applies without merge conflicts.

I just noticed that there was a discussion a year ago
when other developers suggested to use libuuid.

We can see the result of that discussion in the current code:
QEMU does not use libuuid, not even functions with the
same interface. Nor does it include a function to generate
a new UUID value.

There were arguments why QEMU would not need
UUID generation in its code. The VDI block driver
needs UUID generation unless we are satisfied with
dummy or zero values.

My personal preference is using libuuid and the functions
included. For systems without libuuid, a minimalistic
implementation could be provided.

Before I send an update of my patch, I'd like to hear
the opinion of others, especially of the QEMU maintainers.

Regards,
Stefan Weil