[Qemu-devel] Re: [PATCH] slirp: Remove our_addr code

[Jan Kiszka]

Ed Swierk wrote:
> On Thu, Jul 23, 2009 at 1:37 AM, Ed Swierk<address@hidden> wrote:
>> - It's useless: aside from the CU-SeeMe protocol emulation which I
>> propose removing, the only other reference is in get_dns_addr(), but
>> can't imagine why you would want to send DNS requests to a different IP
>> address if you're running a DNS server on the host and resolv.conf
>> points to 127.0.0.1.
>>
>> These problems are easily solved by removing the code.
> 
> Note that VirtualBox removed this code recently as well:
> http://www.virtualbox.org/ticket/1470 .

While I don't consider VirtualBox as a good reference for changing QEMU
code ;), the patch has my conditional ack (depending on the CUSEEME
emulation removal).

Thanks for picking all this up!
Jan

signature.asc
Description: OpenPGP digital signature