qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation.


From: Stuart Brady
Subject: Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation.
Date: Thu, 23 Jul 2009 21:10:06 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

+            dest = args[0];
+            src = args[1];
+            if (const_temps[src]) {
+                const_temps[dest] = 1;
+                dest_val = ~temp_values[src];
+                *opc_ptr = INDEX_op_movi_i32;

Hrm... is it really right to be setting *opc_ptr = INDEX_op_movi_i32
even for 64-bit ops?  Applies to both 'not'[0] and the binary ops...

Cheers,
-- 
Stuart Brady

[0] BTW, the #ifdefs will need shuffling if other unary ops (e.g. neg)
are wanted... it's trivial, but I can't see a reason not to do it. :-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]