qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MAC


From: Nathan Froyd
Subject: Re: [Qemu-devel] [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MACHINE_BSWAP_H
Date: Fri, 24 Jul 2009 13:46:28 -0700
User-agent: Mutt/1.5.13 (2006-08-11)

On Fri, Jul 24, 2009 at 08:30:22PM +0200, Juan Quintela wrote:
> @@ -176,7 +176,7 @@ 
> VPATH+=:$(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>  CPPFLAGS+=-I$(SRC_PATH)/linux-user -I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>
>  ifeq ($(ARCH),i386)
> -ifdef TARGET_GPROF
> +ifdef CONFIG_GPROF
>  USE_I386_LD=y
>  endif
>  ifdef CONFIG_STATIC

I don't see anything obviously wrong with the rest of the patch, but
this hunk and others make it look like you forgot to split out a patch
in your patch series.

-Nathan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]