[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/4] Use 64bit pointer for dirty log
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 2/4] Use 64bit pointer for dirty log |
Date: |
Sat, 25 Jul 2009 01:16:44 +0200 |
Dirty logs currently get written with native "long" size. On little endian
it doesn't matter if we use uint64_t instead though, because we'd still end
up using the right bytes.
On big endian, this does become a bigger problem, so we need to ensure that
kernel and userspace talk the same language, which means getting rid of "long"
and using a defined size instead.
So I decided to use 64 bit types at all times. This doesn't break existing
targets but will in conjunction with a patch I'll send to the KVM ML make
dirty logs work with 32 bit userspace on 64 kernel with big endian.
Signed-off-by: Alexander Graf <address@hidden>
---
kvm-all.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 824bb4c..9d02ce3 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -357,7 +357,7 @@ int kvm_physical_sync_dirty_bitmap(target_phys_addr_t
start_addr,
for (phys_addr = mem->start_addr, addr = mem->phys_offset;
phys_addr < mem->start_addr + mem->memory_size;
phys_addr += TARGET_PAGE_SIZE, addr += TARGET_PAGE_SIZE) {
- unsigned long *bitmap = (unsigned long *)d.dirty_bitmap;
+ uint64_t *bitmap = (uint64_t *)d.dirty_bitmap;
unsigned nr = (phys_addr - mem->start_addr) >> TARGET_PAGE_BITS;
unsigned word = nr / (sizeof(*bitmap) * 8);
unsigned bit = nr % (sizeof(*bitmap) * 8);
--
1.6.0.2
- [Qemu-devel] [PATCH 0/4] PPC KVM bringup patches round 2 v2, Alexander Graf, 2009/07/24
- [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON, Alexander Graf, 2009/07/24
- [Qemu-devel] [PATCH 2/4] Use 64bit pointer for dirty log,
Alexander Graf <=
- [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary, Alexander Graf, 2009/07/24
- [Qemu-devel] [PATCH 4/4] Give the kernel more room, Alexander Graf, 2009/07/24
- Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary, Blue Swirl, 2009/07/25
- Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary, Alexander Graf, 2009/07/25
- Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary, Blue Swirl, 2009/07/27
Re: [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON, Anthony Liguori, 2009/07/27