qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define


From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH 45/46] Remove AUDIO_DRIVERS define
Date: Sun, 26 Jul 2009 14:36:39 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Jan Kiszka wrote:
Avi Kivity wrote:
On 07/26/2009 04:41 PM, Juan Quintela wrote:
The order in audio_drivers is important, that means you can have a
different default sound driver.

After some thinking, my current plan is exporting audio_drv_list
to the Makefile, and then generating something similar to AUDIO_DRIVERS.

Notice that the "ordering" problems not only happens with sound drivers,
we have the same problems with graphics console, which one is the
default one?  It depends on what you have configured, and changing the
default order is far from trivial.
You could pass a goodness value to the registration function, reflecting
what we think the best driver is.  Then at runtime select the best
driver that is supported on the system.


I think the easiest way is to forward the sorted driver list as string
to the audio layer and let it be processed there. Given such an
extension, we could also allow passing a list of drivers via QEMU_AUDIO_DRV.

Sure. Just make audio_init() take an array of strings, have it try and initialize each in that order, then initialize the remaining ones.

I'd say get rid of the compile time ordering entirely. This is the sort of thing that begs for a global configuration file.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]