qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/5] Remove setvbuf(<handle>, NULL, _IOLBF, 0) c


From: Daniel Jacobowitz
Subject: Re: [Qemu-devel] [PATCH 3/5] Remove setvbuf(<handle>, NULL, _IOLBF, 0) calls for Win32
Date: Mon, 27 Jul 2009 09:21:23 -0400
User-agent: Mutt/1.5.20 (2009-06-14)

On Mon, Jul 27, 2009 at 10:02:04AM +0000, Filip Navara wrote:
> On Win32 the setvbuf function requires the last parameter to be size between 
> 2 and INT_MAX bytes, so the calls always failed. Since the whole point of the 
> calls is to set line-buffered mode for the file handle and that's not 
> supported on Win32 anyway, conditionally remove them.

Should they be unbuffered where _IOLBF is not supported, then?  I
assume the line buffering was to make them more useful in event of a
crash.

-- 
Daniel Jacobowitz
CodeSourcery




reply via email to

[Prev in Thread] Current Thread [Next in Thread]