Re: [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON

[Anthony Liguori]

Alexander Graf wrote:
> MP State is implemented in the generic code, so let's move the variable
> it accesses to generic code as well.
>
> Unbreaks PPC w/ KVM.
>   

And breaks the build for everyone else.

You change mp_state from a uint32_t to a int, but then there's:

target-i386/machine.c:

   qemu_put_be32s(f, &env->mp_state);

Which expects a uint32_t.

Regards,

Anthony Liguori