[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] fix endless look at kvm migration
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH] fix endless look at kvm migration |
Date: |
Mon, 27 Jul 2009 20:44:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Glauber Costa wrote:
> If we try to sync bitmaps withouth KVM_MEM_LOG_DIRTY_PAGES being set
> on a slot, we will enter an endless loop. Remove the test, since it
> is not strictly needed anyway
>
> Signed-off-by: Glauber Costa <address@hidden>
> CC: Alexander Graf <address@hidden>
> ---
> kvm-all.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 824bb4c..d3bbd3c 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -331,11 +331,6 @@ int kvm_physical_sync_dirty_bitmap(target_phys_addr_t
> start_addr,
> break;
> }
>
> - /* We didn't activate dirty logging? Don't care then. */
> - if(!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES)) {
> - continue;
> - }
> -
> size = ((mem->memory_size >> TARGET_PAGE_BITS) + 7) / 8;
> if (!d.dirty_bitmap) {
> d.dirty_bitmap = qemu_malloc(size);
Please let us revert the whole bd83677.
Jan
signature.asc
Description: OpenPGP digital signature