qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove I


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro
Date: Mon, 27 Jul 2009 18:02:07 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

malc wrote:
On Mon, 27 Jul 2009, Juan Quintela wrote:

This patch is pointless.

The INIT_FIELD() stuff is goofy. struct initializers are C99 so using them conditionally on GNUC is incorrect. Also, if you can't rely on the initializier, what's the point of even doing it at all since you cannot change order.

Removing INIT_FIELD() is a big improvement IMHO.

--
Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]