[Qemu-devel] Re: [PATCH 1/4] Use proper struct initializers and remove INIT_FIELD() macro

[malc]

On Tue, 28 Jul 2009, Juan Quintela wrote:

> malc <address@hidden> wrote:
> > On Mon, 27 Jul 2009, Anthony Liguori wrote:
> >
> >> malc wrote:
> >> > On Mon, 27 Jul 2009, Juan Quintela wrote:
> >> > 
> >> > This patch is pointless.
> >> >   
> >> 
> >> The INIT_FIELD() stuff is goofy.  struct initializers are C99 so using 
> >> them conditionally on GNUC is incorrect.  Also, if you can't rely on the 
> >> initializier, what's the point of even doing it at all since you cannot 
> >> change order.
> >
> > The reason for this goofyness is that the code was fed as is to MSVC
> > (in VirtualBox), the patch looks like a change for the sake of a change.
> 
> MSVC don't support C99 initializers in 2009? Wow :)

Sadly i've no idea what the latest and greatest MSVC does or does not 
support.

> 
> I was trying to get everything else consistent.

Yes i understand the motivation.

-- 
mailto:address@hidden