Re: [Qemu-devel] [PATCH] alsa broken when the host is suspended (or hibernated)

[malc]

On Wed, 29 Jul 2009, Bjrn Mork wrote:

> audio output fails after resuming a host running a guest using alsa
> audio output. Messages such as
> 
>  alsa: Failed to write 882 frames to 0x1804b98
>  alsa: Reason: Streams pipe error
> 
> will appear repeatedly in the monitor.  This is caused by alsaaudio.c
> not handling ESTRPIPE.  Fix this by calling snd_pcm_resume() on
> ESTRPIPE.
> 
> This bug is similar to the vlc bug discussed on
> https://trac.videolan.org/vlc/ticket/1286 and the fix is insired by
> the patch attached to that bug report
> 
> Signed-off-by: BjЪЪrn Mork <address@hidden>
> ---
>  audio/alsaaudio.c |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)

Thank you. I've massaged the patch a bit:

a. Trimmed the comment line to fit 80 columns
b. Suppressed tabs
c. Added -ESTRPIPE handling to alsa_run_in
d. Changed the verbose message to indicate which of the streams
   is being resumed (input/output)

It would be very nice if you could verify that it still works since
my machine is not capable of suspending nor hibernating, it would be
very informative if you could run audio capture inside the guest to
verify c. and d.

The tree is at:
http://repo.or.cz/w/qemu/malc.git?a=shortlog;h=refs/heads/alsa

Or you can just apply first commit's patch.

[..snip..]

P.S. Perhaps you could also come up with a better subject line?

-- 
mailto:address@hidden