[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2 of 3] a single vnc server surface
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 2 of 3] a single vnc server surface |
Date: |
Wed, 29 Jul 2009 15:40:15 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Wed, 29 Jul 2009, Gerd Hoffmann wrote:
> On 07/29/09 14:09, Stefano Stabellini wrote:
> > This patch removes the server surface from VncState and adds a single
> > server surface to VncDisplay for all the possible clients connected.
> > Each client maintains a different dirty bitmap in VncState.
> > The guest surface is moved to VncDisplay as well because we don't need
> > to track guest updates in more than one place.
>
> I doubt you did any copyrect testing. It is broken in master[1], and
> this patch breaks it even more.
No I didn't: I notice that your fix wasn't applied yet but can be easily
applied on top of this patch and I just decided to rely on that.
You just have to s/vs->server.ds/vd->server/g.