|
| From: | Paolo Bonzini |
| Subject: | [Qemu-devel] Re: [PATCH 19/25] monitor: Split monitor_handle_command() |
| Date: | Wed, 29 Jul 2009 17:31:54 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
+ if (cmd) {
+ void (*handler)(Monitor *mon, const struct qemu_dict *qdict);
+ handler = cmd->handler;
+ handler(mon, qdict);
+ }
I'd prefer cmd->handler(mon, qdict). One less place to change if you change the arguments later.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |