Re: [Qemu-devel] Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA

[Jordan Justen]

On Wed, Jul 29, 2009 at 10:15 AM, Anthony Liguori<address@hidden> wrote:
> Jordan Justen wrote:
>>
>> On Mon, Jun 8, 2009 at 2:53 PM, Anthony Liguori<address@hidden>
>> wrote:
>>
>>>
>>> Anthony Liguori wrote:
>>>
>>>>
>>>> This is needed for VMware VGA to work properly under KVM.
>>>>
>>>> Signed-off-by: Anthony Liguori <address@hidden>
>>>> ---
>>>>  hw/vmware_vga.c |    4 ++++
>>>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
>>>> index bb17698..246011b 100644
>>>> --- a/hw/vmware_vga.c
>>>> +++ b/hw/vmware_vga.c
>>>> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice
>>>> *pci_dev,
>>>> int region_num,
>>>>  #endif
>>>>    cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
>>>>                    iomemtype);
>>>> +
>>>> +    s->vga.map_addr = addr;
>>>> +    s->vga.map_end = addr + s->vga.vram_size;
>>>> +    vga_dirty_log_start(&s->vga);
>>>>  }
>>>>
>>>>  void pci_vmsvga_init(PCIBus *bus)
>>>>
>>>>
>>>
>>> N.B. depth is still screwed up with VMware vga but the fix for that looks
>>> a
>>> bit more non-obvious.  This VBE issue has been a long standing problem
>>> though and I suspect it effects other guests though.
>>>
>>>
>>
>> I've tried booting Ubuntu 8.10/9.04 using '-vga vmware' on various
>> versions of
>> kvm and qemu.  The result is always ok video during BIOS post, but garbage
>> during pre and post X.  Would this be a symptom of the 'VBE' issue that
>> you mentioned?
>>
>
> Try the latest qemu git.  vmware vga should work there.
>
> I'm not sure about qemu-kvm.  It depends on whether the changes survived the
> merge.
>

Yes, this is one of the combinations I tried.  Latest qemu from git with your
two patches applied.

Do you have another distro which you might recommend trying?  (Although,
I'm not too confident this would be the problem.)

> Regards,
>
> Anthony Liguori
>