Re: [Qemu-devel] [PATCH] kvm: add kvm version to the "info kvm" monitor command

[Luiz Capitulino]

On Wed, 29 Jul 2009 17:48:13 -0300
Glauber Costa <address@hidden> wrote:

> On Wed, Jul 29, 2009 at 3:48 PM, Luiz Capitulino<address@hidden> wrote:
> > On Wed, 29 Jul 2009 13:03:38 +0200
> > Bjørn Mork <address@hidden> wrote:
> >
> >> There isn't a one-to-one mapping between the KVM version and
> >> the QEMU version output from "info version".  Complete the
> >> picture by adding the KVM version to the existing "info kvm"
> >> monitor command.
> >>
> >>  (qemu) info kvm
> >>  kvm support: enabled
> >>  kvm version: kvm-85
> >
> >  Doesn't seem a good idea, as this is considered a stable protocol.
> >
> >  Either, we should check current users or add 'info kvm-version'.
> 
> can't see why. We recently added information to info migrate, and many others.
> If we are using a new line, shouldn't matter, since it is expected that 
> parsers
> for those things would be line based.

 I don't think this is a safe assumption if you take it literally
for all the commands. If I remember correctly, libvirt for example,
expects the string '(qemu)' as a meaning of 'command executed',
in this case anything different could cause problems.

 I would have to check the code to be certain, though. But will
not matter anyway, if 'info kvm' has no users.

> Not only I'd like to see this, I would also like to see information of
> kvm itself being
> more verbose, like whether or not we have in kernel irqchip/pit

 Yes, this is really useful. I'm just concerned with current
users and when I started working on the monitor protocol people have
clearly expressed their concern on not changing commands output.

 I also should add that I would be extremely happy to find out
that monitor's output could be changed. :)