[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS |
Date: |
Thu, 30 Jul 2009 09:16:59 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> Just wanted to point out that this is wrong. -I and -D *are* CPPFLAGS.
Tell that to sdl-config --cflags and friends :p
> However, the real issue is that CFLAGS should be reserved for the user
> at make time (defaulting to something *constant* like -O2 -g or
> whatever else). Actually so should CPPFLAGS, but at least it is much
> less likely to be used, while "make CFLAGS=-g" is common during
> development and supported by almost every package I know of.
>
> You can also call it QEMU_CPPFLAGS or QEMU_CFLAGS and we can be happy.
> You then have to add both $(QEMU_CPPFLAGS) and $(CFLAGS) to
> compilation commands in both configure and Make.
If there is an agreement about that, I don't care remaining. As things
stand now, the difference between CFLAGS and CPPFLAGS in qemu was
artificial.
Later, Juan.
- [Qemu-devel] [PATCH 23/42] We use -lz for all binaries, (continued)
- [Qemu-devel] [PATCH 23/42] We use -lz for all binaries, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 24/42] We want to pass LIB through configuration files now, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 21/42] refactor $cpu selection in various places, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 25/42] PTHREADLIBS was used for all binaries, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 26/42] CLOCKLIBS was used for all binaries, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 27/42] Move to configure CONFIG_SOLARIS libraries needed always, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 28/42] Move to configure CONFIG_WIN32 libraries needed always, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 29/42] We set -Werror through configure now, Juan Quintela, 2009/07/29
- [Qemu-devel] [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/29
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Paolo Bonzini, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS,
Juan Quintela <=
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Paolo Bonzini, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Paolo Bonzini, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/30
- Re: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Jamie Lokier, 2009/07/30
- [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, Juan Quintela, 2009/07/30
- Re: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS, malc, 2009/07/30
[Qemu-devel] [PATCH 32/42] move common CFLAGS to configure, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 33/42] Refactor HELPER_CFLAGS, Juan Quintela, 2009/07/29
[Qemu-devel] [PATCH 31/42] split CFLAGS very long line, Juan Quintela, 2009/07/29