qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] Remove the virtio-{blk, console}-pci-0-10 d


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 2/2] Remove the virtio-{blk, console}-pci-0-10 device types
Date: Thu, 30 Jul 2009 14:22:16 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 07/30/09 12:29, Mark McLoughlin wrote:
These are now unused.

However, perhaps the idea is that when we add -device, they will be
useful? In that case, we should add virtio-net-pci-0-10 too.

With -device you can switch devices into compat mode by simply setting the attribute. Doesn't work (yet) because you can't create functional virtio console+block devices via -device right now. I'll plan to have that fixed at least for virtio blk soon though. For virtio-net this can be done today (-net nic,model=virtio,vectors=0 turns off msi).

So IMHO there is no need in keeping the device types and the patch should be applied.

Acked-by: Gerd Hoffmann <address@hidden>

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]