Re: [Qemu-devel] [PATCH] Add support for vmware vmdk scsi images to qemu-img

[Pantelis Koukousoulas]

On Thu, Jul 30, 2009 at 7:27 PM, Paul Brook<address@hidden> wrote:
> On Thursday 30 July 2009, Pantelis Koukousoulas wrote:
>> This adds support to qemu-img for creating vmdk scsi images.
>> (It currently creates only IDE ones).
>> Original version was from Soren Hansen.
>
> Wasn't this (adding generic code for vmware specific nonsense attributes)
> already rejected once?
>
> http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg01131.html

Thanks, I hadn't seen this thread to be honest (don't know how I missed it,
I only found the much older patch from Soren).

I read the thread and it seems the most important reason for the rejection
was the fact that this patch wanted to add a new global option to qemu-img
(-S). My patch doesn't try to do that, it only adds a new "-o scsi=on" to
the vmdk format.

Wrt to scsi not being useful for qemu itself though, I have to agree.
Nevertheless, this patch is very small and trivial and qemu-img usage as
a "swiss-army knife" for converting image format for various VMMs/emulators
is pretty common imho.

If you still think the same reasons for rejection apply, is there any reasonably
small change that could be made to the patch to make it more acceptable?

Thanks,
Pantelis