[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] QemuOpts: add some functions
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] QemuOpts: add some functions |
Date: |
Fri, 31 Jul 2009 11:54:57 -0300 |
On Fri, 31 Jul 2009 12:25:32 +0200
Gerd Hoffmann <address@hidden> wrote:
> qemu_opt_foreach: loop over all QemuOpts entries.
> qemu_opts_id: return QemuOpts id.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qemu-option.c | 19 +++++++++++++++++++
> qemu-option.h | 4 ++++
> 2 files changed, 23 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-option.c b/qemu-option.c
> index 591d178..7164ee8 100644
> --- a/qemu-option.c
> +++ b/qemu-option.c
> @@ -607,6 +607,20 @@ int qemu_opt_set(QemuOpts *opts, const char *name, const
> char *value)
> return 0;
> }
>
> +int qemu_opt_foreach(QemuOpts *opts, qemu_opt_loopfunc func, void *opaque,
> + int abort_on_failure)
> +{
> + QemuOpt *opt;
> + int rc = 0;
> +
> + TAILQ_FOREACH(opt, &opts->head, next) {
> + rc = func(opt->name, opt->str, opaque);
> + if (abort_on_failure && rc != 0)
> + break;
> + }
> + return rc;
> +}
> +
> QemuOpts *qemu_opts_find(QemuOptsList *list, const char *id)
> {
> QemuOpts *opts;
> @@ -663,6 +677,11 @@ int qemu_opts_set(QemuOptsList *list, const char *id,
> return qemu_opt_set(opts, name, value);
> }
>
> +const char *qemu_opts_id(QemuOpts *opts)
> +{
> + return opts->id;
> +}
> +
Can't you constify *opts in those functions?
- [Qemu-devel] [PATCH 0/10] QemuOpts+qdev patches., Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 01/10] QemuOpts: add some functions, Gerd Hoffmann, 2009/07/31
- Re: [Qemu-devel] [PATCH 01/10] QemuOpts: add some functions,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 02/10] QemuOpts: qemu_opts_parse: fix id= parsing, Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 05/10] QemuOpts: add -set option, Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 03/10] QemuOpts: make the drive id actually show up in "info block"., Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 09/10] qdev/prop: add drive property., Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 07/10] constify drive_get_by_id arg, Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 08/10] add -drive if=none, Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 04/10] QemuOpts: create qemu-config.h, Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 10/10] qdev-ify virtio-blk., Gerd Hoffmann, 2009/07/31
- [Qemu-devel] [PATCH 06/10] QemuOpts: switch over -device., Gerd Hoffmann, 2009/07/31