|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH v1 00/25] Monitor handlers new structure phase 1 |
Date: | Mon, 10 Aug 2009 15:17:03 -0500 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Luiz Capitulino wrote:
Hi there, In the long QEMU Monitor Protocol (QMP) thread people have agreed that, whichever protocol we are going to use, the first step that needs to be done is to improve current Monitor's code, so that command handlers support 'structured' input and output.
I think one of the goals was for there to be type safety. qdicts store void *s which is pretty clumsy.
I think you may be waiting to introduce QObject, but in the interim, you should at least introduce a boxed type and have proper accessors in qdict. For instance, instead of:
int f = (long)qdict_get(foo, "bar"); It should be: int f = qdict_get_int(foo, "bar"); Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |