Re: [Qemu-devel] [PATCH v1 00/25] Monitor handlers new structure phase 1

[Luiz Capitulino]

On Mon, 10 Aug 2009 15:17:03 -0500
Anthony Liguori <address@hidden> wrote:

> Luiz Capitulino wrote:
> >  Hi there,
> >
> >  In the long QEMU Monitor Protocol (QMP) thread people have agreed that,
> > whichever protocol we are going to use, the first step that needs to be
> > done is to improve current Monitor's code, so that command handlers
> > support 'structured' input and output.
> >   
> 
> I think one of the goals was for there to be type safety.  qdicts store 
> void *s which is pretty clumsy.

 Yes.

> 
> I think you may be waiting to introduce QObject, but in the interim, you 
> should at least introduce a boxed type and have proper accessors in 
> qdict.  For instance, instead of:
> 
> int f = (long)qdict_get(foo, "bar");
> 
> It should be:
> 
> int f = qdict_get_int(foo, "bar");

 It will be provided by the QObject patches I'm already
working on, why can't we wait for it?

 The current code also stores handler arguments as void pointers
and does the casting when passing them as arguments.

 So, unless you have caught a real bug in the series, I think
it's safe to merge it as is. This will contribute to have
QObject sooner. :)

 Also, it's a good idea to get this tested before introducing
another layer on top of it.