Re: [Qemu-devel] [PATCH v1 00/25] Monitor handlers new structure phase 1

[Luiz Capitulino]

On Mon, 10 Aug 2009 15:45:17 -0500
Anthony Liguori <address@hidden> wrote:

> Luiz Capitulino wrote:
> >> I think you may be waiting to introduce QObject, but in the interim, you 
> >> should at least introduce a boxed type and have proper accessors in 
> >> qdict.  For instance, instead of:
> >>
> >> int f = (long)qdict_get(foo, "bar");
> >>
> >> It should be:
> >>
> >> int f = qdict_get_int(foo, "bar");
> >>     
> >
> >  It will be provided by the QObject patches I'm already
> > working on, why can't we wait for it?
> >   
> 
> Lack of type safety is a rather fundamental flaw.  It's hard to judge 
> whether qdict is correct because it's fundamentally flawed in it's 
> current form.

 It's as simple as the current code.

> Maybe you should take the opposite approach?  Introduce QObject along 
> with a type-safe qdict and then do the monitor command conversion.

 This is an option, although will make the series larger and harder
to review.

> I feel like merging qdict as is would be a regression because it makes 
> the monitor commands even less type safe then they were before.

 I have the impression it's the same thing, but at this point
it wouldn't be too difficult for me to move QObject patches to
the beginning of the series.