Re: [Qemu-devel] [PATCH] Add support for vmware vmdk scsi images to qemu-img

[Kevin Wolf]

Anthony Liguori schrieb:
> Pantelis Koukousoulas wrote:
>> diff --git a/block_int.h b/block_int.h
>> index 830b7e9..0311198 100644
>> --- a/block_int.h
>> +++ b/block_int.h
>> @@ -30,10 +30,12 @@
>>  #define BLOCK_FLAG_ENCRYPT  1
>>  #define BLOCK_FLAG_COMPRESS 2
>>  #define BLOCK_FLAG_COMPAT6  4
>> +#define BLOCK_FLAG_SCSI         8
> 
> The flag space is limited and I don't want to pollute it with options 
> that are of no use to QEMU.  If you were able to limit the impact of 
> this patch to just block/vmdk.c, we would be more likely to consider 
> it.  That may require a greater refactoring of how options work though.

Well, yes, a refactoring as great as using a local int scsi instead of
defining a global constant to be or-ed into a local int flags... ;-)
Actually I think we could drop these global BLOCK_FLAG_* completely
without losing anything.

And otherwise the patch already is completely local to VMDK.

Kevin