|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH] isa_reserve_irq() |
Date: | Wed, 12 Aug 2009 17:28:35 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 08/12/09 17:10, Jes Sorensen wrote:
On 08/12/2009 04:58 PM, Gerd Hoffmann wrote:On 08/12/09 16:42, Jes Sorensen wrote:Hi Gerd, This looks great! I have implemented isa_reserve_irq() on top of this. It allows one to reserve ISA irqs without converting them to qdev, which for certain interrupts makes sense,which ones?ferr
Ah, that one.
I think that deserves a comment clearly stating that this interface is a (temporary?) thing for not-yet converted devices. Otherwise it looks fine to me.If you think it makes sense to convert ferr as well, then I'll be happy to add the comment.
Hmm, I don't think it makes sense to pull a dummy device out of thin air, isa_reserve_irq() will do fine. But it should be be clearly documented that this is for this special case and not-yet converted devices. qdev-ified devices should use the other isa_*_irq functions instead.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |