The 'i' argument type is for 32-bit only and most handlers
will use an 'int' to store its value.
It's better to fail gracefully when the user enters a value
greater than 32-bit than to get subtle casting bugs.
Signed-off-by: Luiz Capitulino<address@hidden>
---
monitor.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index e736de4..2052c00 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2820,6 +2820,12 @@ static const mon_cmd_t *monitor_parse_command(Monitor
*mon,
}
if (get_expr(mon,&val,&p))
goto fail;
+ /* Check if 'i' is greater than 32-bit */
+ if ((c == 'i')&& ((val>> 32)& 0xffffffff)) {
+ monitor_printf(mon, "\'%s\' has failed: ", cmdname);
+ monitor_printf(mon, "integer is for 32-bit values\n");
+ goto fail;
+ }
qdict_add_qint(qdict, key, qint_from_int64(val));
}