|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH] switch balloon initialization to -device. |
Date: | Fri, 14 Aug 2009 12:10:02 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 08/14/09 11:44, Markus Armbruster wrote:
Gerd Hoffmann<address@hidden> writes:With that patch applied "-balloon virtio,args" becomes a shortcut for "-device virtio-balloon-pci,args". Side effects: - ballon device gains support for id=<tag>. - ballon device is off by default now. - initialization order changes, which may in different pci slot assignment depending on the VM configuration. Signed-off-by: Gerd Hoffmann<address@hidden>Looks good on quick inspection (gotta run), just one question: what happens when I (stupidly) do -balloon virtio,driver=e1000 ? Question might apply to plain -device before this patch as well.
QemuOpts allows overwriting, so who is written last will win. Write order is undefined, so don't try that at home ;) Behavior of the current code: -balloon virtio,driver=e1000 will give you a balloon device. -device virtio-blk-pci,driver=e1000 will give you a e1000. cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |