[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/8] ide: split away ide-isa.c
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 2/8] ide: split away ide-isa.c |
Date: |
Wed, 19 Aug 2009 11:53:48 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Reviewed-by: Juan Quintela <address@hidden>
Reply-to: address@hidden
Gerd Hoffmann <address@hidden> wrote:
> create ide.h and ide-internal header files. ide-internal.h is supposed
> to be used by ide*.c only.
>
> create ide-isa.c and place isa bus support there.
> only build ide-isa support for platforms using it.
> --- /dev/null
> +++ b/hw/ide-internal.h
> @@ -0,0 +1,97 @@
> +#ifndef HW_IDE_INTERNAL_H
> +#define HW_IDE_INTERNAL_H
> +
Add a comment stating something in the lines of:
/* IDE internal definitions
if you are not an ide-*.c file, you should not load it
*/
> diff --git a/hw/ide-isa.c b/hw/ide-isa.c
> new file mode 100644
> index 0000000..2d65825
> --- /dev/null
> +++ b/hw/ide-isa.c
> @@ -0,0 +1,45 @@
> +/*
> + * QEMU IDE disk and CD/DVD-ROM Emulator
> + *
QEMU IDE Bus abstraction?
Again, only nitpits, agreed with the reorganization.
- [Qemu-devel] [PATCH 0/8] ide: cleanup and splitting., Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 3/8] ide: add save/restore support for isa, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 2/8] ide: split away ide-isa.c, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] Re: [PATCH 2/8] ide: split away ide-isa.c,
Juan Quintela <=
- [Qemu-devel] [PATCH 1/8] ide: add IDEBus struct, cleanups, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 4/8] ide: split away ide-pci.c, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 7/8] ide: add save/restore support for mmio, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 6/8] ide: split away ide-mmio.c, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 8/8] ide: split away ide-microdrive.c, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 5/8] ide: split away ide-macio.c, Gerd Hoffmann, 2009/08/18
- Re: [Qemu-devel] [PATCH 0/8] ide: cleanup and splitting., Avi Kivity, 2009/08/18