[Qemu-devel] Re: [PATCH 04/29] Introduce QDict

[Avi Kivity]

On 08/20/2009 06:08 PM, Luiz Capitulino wrote:
> > The current code, no, but once we read qdicts from the monitor, you need
> > to be able to handle { a: 1, a: 2 }.
> >      
>   qdict_add() will refuse to add an existing key, but I can change
> it to replace instead.
>
>   Would this be enough?
>    

Yes, that's the standard behaviour.  Rename it qdict_put() though.



> > > > This assumption does not hold if the dict came from a user.
> > > >
> > > >          
> > >    Then the user has to know what he or she is doing. :)
> > >
> > >        
> > They don't, as a rule.
> >      
>   That's why there's an assert() there. :)
>    

You don't want user input triggering asserts (I'm talking user in the 
sense of something external to the program, not in the sense of code in 
qemu using this function).

--
error compiling committee.c: too many arguments to function