[Qemu-devel] Re: [PATCH 0/10] ide: cleanup and splitting.

[Juan Quintela]

Gerd Hoffmann <address@hidden> wrote:
>   Hi,
>
> Next round of the ide cleanup and splitting series.  Changes:
>
>  * Creating ide-internal.h is a separate patch now.
>  * Comments of the new files have been fixed to actually describe
>    the file content instead of being a simple cut+paste from ide.c
>  * There is a new patch (last one) which moves all ide code into a
>    new hw/ide/ subdirectory as suggested by avi.

Acked-by: Juan Quintela <address@hidden>

Already liked the 1st series.  This one addresed all my nitpits.
Only one remained is that in the 1st patch, there are places with
whitesace/tab damage. (damage was already there).

In function ide_ioport_write()

-       ide_clear_hob(ide_if);
+       ide_clear_hob(bus);
         /* NOTE: data is written to the two drives */
-       ide_if[0].hob_feature = ide_if[0].feature;
-       ide_if[1].hob_feature = ide_if[1].feature;
-        ide_if[0].feature = val;
-        ide_if[1].feature = val;
+       bus->ifs[0].hob_feature = bus->ifs[0].feature;
+       bus->ifs[1].hob_feature = bus->ifs[1].feature;
+        bus->ifs[0].feature = val;
+        bus->ifs[1].feature = val;

If you have to respin the series, consider fixing it once that you are there.

Later, Juan.