Re: [Qemu-devel] [PATCH 21/23] Port PCIDevice state to VMState

[Gerd Hoffmann]

On 08/20/09 19:42, Juan Quintela wrote:
> This uses a variant of buffer, with extra checks. Also uses the new
> support for cheking that a read value is less or equal than a field.

Hmm, why you are hopping through all these loops?

I'd just keep the existing pci_device_{save,load} functions.  load 
anyway for backward compatibility.  save also for devices not yet 
converted to vmstate.  I think alot of the complex stuff you are 
building up here isn't needed then, unless I missed something ...

Beside that we'll have to think about how to handle versioning of 
structs.  Do we want vmstate_pci_device (and all others) have its own 
version?  Probably makes sense.  Handling this should go into the 
generic code then and not be hacked into each structure using 
VMSTATE_INT32_LE().

cheers,
  Gerd