[Qemu-devel] Re: [PATCH 03/14] configure stellaris device only for arm softmmu

[Juan Quintela]

Paolo Bonzini <address@hidden> wrote:
>>   # What drivers should we compile
>>   ssi_bus=no
>> +stellaris=no
>
> What about calling these CONFIG_SSI CONFIG_STELLARIS etc. already in
> configure, and initializing them with
>
> : ${CONFIG_SSI=n}
> : ${CONFIG_STELLARIS=n}
>
>> @@ -2236,6 +2238,10 @@ if test "$ssi_bus" = "yes" ; then
>>       echo "CONFIG_SSI=y">>  $config_host_mak
>>   fi
>>
>> +if test "$stellaris" = "yes" ; then
>> +    echo "CONFIG_STELLARIS=y">>  $config_host_mak
>> +fi
>
> Then you can:
>
> 1) save duplication using
>
> for i in CONFIG_SSI CONFIG_STELLARIS; do
>   case \$$i in
>   if test "$config_var" = y; then
>     echo "$i=y">> $config_host_mak
>   fi
> done
>
> 2) allow the user to force your choice by setting environment
> variables when calling configure (not sure how useful this is).
>
> Otherwise, looks nice!

I would do the other way around :)
I.e. always print
CONFIG_STELLARIS=y
or
CONFIG_STELLARIS=n

That will move from 3 lines to 1 line.

About the big problem, is that in configure, we have 2 kinds of
variables:
- configure variables: usually lowercase
- variables for build system: usually uppercase

Notice that current code does a mess at distinguishing them, it _mainly_
is the way I have described.  About your way, perhaps itis a better
idea, to _always_ use the configure names, that way we don't have to
"translate" from one name to the other.

Later, Juan.