[Qemu-devel] Re: [PATCH 00/22] Indirection Cleanup

[Juan Quintela]

Gerd Hoffmann <address@hidden> wrote:
> On 08/24/09 13:03, Juan Quintela wrote:
>> This patch series clean up "half" converted qemu drivers that had changed 
>> from:
>>
>> struct FOOState
>>
>> to
>>
>> typedef PCIFOOState {
>>      PCIDevice dev;
>>      FOOState foo;
>> } PCIFOOState;
>>
>> It just moves PCIDevice to be the 1st field of FOOState.
>
> Note that there are a bunch of cases where it actually makes sense to
> have PCIFOOState because foo can be connected to different busses and
> thus there is a ISAFOOState (or will be once ISA is qdevified too).
>
> Disclaimer: did't look through the patches yet, just scanned the
> subjects.  But I've seen ne2000 + vga on the list.  For both devices
> ISA variants exist.  Likewise OHCI, there are also non-PCI variants.

on the PCI/ISA difference:
* ne2000: just looked again at it, we could probably found a way to get
  that around.
* vga: this needs major refactoring.
* OHCI: I did the change, and everything compiled, didn't found the
  other uses :p

I didn't changed it because then I had to replicate the save/load
functions. (looking at it again, it appears that this ones are the only diff)

>> - pcnet:  It needs a different approach, because it can be both a PCIDevice
>>    or a SysBus device.
>
> That one too ;)
> Why do you want to change it?

PCNetState first field is

PCIDevice *pci_dev.

and that device is also for lance.  Will take a look at your approach
for diferentaiting them.

Later, Juan.