Re: [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter for the pc target.

[Avi Kivity]

On 08/25/2009 08:11 PM, Lennart Sorensen wrote:
> On Tue, Aug 25, 2009 at 07:56:50PM +0300, Avi Kivity wrote:
>    
> > Our users will hate us if we do this.  We should look at XP's actual
> > market share, not formal statements from Microsoft.  If market share
> > starts dropping, we can scale back support in qemu.
> >
> > Providing less than optimal performance is a lot better than starting up
> > with no networking.  In any case optimal performance requires a
> > non-default selection (virtio).
> >      
> Well if e1000 gives 95% of the virtio performance, and 8139 gives 50%,
> then I know which I will be using.  Personally I don't care which one
> is default, since I will use e1000 with bridging anyhow.
>    

if (0) is usually optimized away by the compiler.

The default only matters to unmanaged systems.  I think we should aim 
first for working, and later for performance.

--
error compiling committee.c: too many arguments to function