Re: [Qemu-devel] [PATCH 70/81] remove last 3 uses of :=, everywhere else uses += or =

[Hollis Blanchard]

On Mon, Aug 3, 2009 at 5:47 AM, Juan Quintela<address@hidden> wrote:
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  Makefile.target |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index a4d269d..6b3d40f 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -20,7 +20,7 @@ endif
>  PROGS=$(QEMU_PROG)
>
>  ifeq ($(subst ppc64,ppc,$(ARCH))$(TARGET_BASE_ARCH),ppcppc)
> -translate.o: QEMU_CFLAGS := $(QEMU_CFLAGS) $(call cc-option, $(QEMU_CFLAGS), 
> -fno-unit-at-a-time,)
> +translate.o: QEMU_CFLAGS += $(call cc-option, $(QEMU_CFLAGS), 
> -fno-unit-at-a-time,)
>  endif
>
>  LIBS+=-lm

This change breaks the build with PPC host and PPC target:
Makefile:25: *** Recursive variable `QEMU_CFLAGS' references itself
(eventually).  Stop.

I don't know why you want to remove all :=, but it seems like this
hunk should be reverted.

-Hollis