[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Coding style, C++ compatible code (was Re: [Qemu-devel] [PATCH 02/22
From: |
Måns Rullgård |
Subject: |
Re: Coding style, C++ compatible code (was Re: [Qemu-devel] [PATCH 02/22] eepro100: cast a void * makes no sense) |
Date: |
Thu, 27 Aug 2009 00:00:00 +0100 |
User-agent: |
Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.22 (Instant Classic, linux) |
Kent Harris <address@hidden> writes:
> Stefan,
>
> I'm with you 100 percent. I already complained to this group a couple
> of months ago about the void* casting issue (and also using "private"
> as a structure element name as that barfs C++ as well -- there are
> others.)
>
> For my situation, these problems within C-language source files are
> not an issue but when they occur inside a QEMU header file that I must
> include from my C++ device models, my compilations fail.
> Consequently, I have a whole series of patch files to the QEMU source
> that I have to apply to correct these (trivial) coding errors. Each
> time a new QEMU release comes out, I have to recreate the patch
> files. Frustrating to say the least.
#define private cxx_private
#include <qemu.h>
#undef private
Job done.
--
Måns Rullgård
address@hidden