[Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux native AIO support

[Riku Voipio]

On Fri, Aug 28, 2009 at 02:38:57PM +0400, malc wrote:
> -        } else if (s->use_aio) {
> +        }
> +        else if (s->use_aio) {
> +#ifdef CONFIG_LINUX_AIO
>              return laio_submit(bs, s->aio_ctx, s->fd, sector_num, qiov,
> -                            nb_sectors, cb, opaque, type);
> +                               nb_sectors, cb, opaque, type);
> +#else
> +            abort();
> +#endif

use_aio is only ever set in CONFIG_LINUX_AIO protected section, so the #else
section is not needed. Even if that were not the case, falling back to 
paio_submit()
feels like a better idea than aborting emulation.

fwiw, s->use_aio is a bad name as well, as it refers to linux aio, while the
file also supports posix aio...