Re: [Qemu-devel] [PATCH 0/7] ATAPI CDROM passthrough v5

[Bique Alexandre]

On Wednesday 12 August 2009 17:18:13 Ian Jackson wrote:
> I've picked up Alex's patch series for this.  Changes since v4:
>   * rebased to current tip as of approximately yesterday
>   * passthrough of firmware update is enabled by default
>   * fixed some build issues
>
> Anthony Liguori wrote:
> > This series breaks the cris-softmmu build.
>
> I think I've fixed it up.  It builds for me, anyway.  If it now
> doesn't build do please tell me the error message and I'l fix it.
>
> > Also, I think Paul and I both requested that fw upgrade not be
> > disabled by default.
>
> As previously discussed I think this is a mistake, but it's a decision
> for qemu upstream to make so I have changed this.
>
> >   I would also suggest that you only expose this as an option
> > through qdev properties instead of a new command line option as it
> > should be controllable on a per-device basis.
>
> The reason to disable it is not to prevent the guest breaking the
> hardware.  It is to prevent the guest escaping the containment
> entirely, which it can probably do if firmware updates are allowed.
> This seems to me to be a general property of the guest, rather than of
> the device.  So I think disabling it in one place is better.
>
> Patches follow.

Hi Ian,

Are you going to continue to work on this patch queue or do you want me to 
finish the job ?

Thanks a lot.

-- 
Alexandre Bique