qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/2] Remove CFLAGS parameter in cc-option


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 1/2] Remove CFLAGS parameter in cc-option
Date: Mon, 31 Aug 2009 08:54:14 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3

On 08/31/2009 12:48 AM, Juan Quintela wrote:
With cc-option we are testing if gcc just accept a particular option, we don't 
need CFLAGS at all.

ACK, however these should IMO be moved to configure.  This:

CFLAGS += $(call cc-option, -fno-stack-protector,"")

is likely responsible of at least 20% system time to the compilation (because one normal compilation costs three forks for gcc+cc1+as, and cc-option costs two more for gcc+cc1).

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]