|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 0/5] qdev: device capabilities |
Date: | Tue, 08 Sep 2009 08:52:45 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 |
On 09/07/09 22:36, Anthony Liguori wrote:
Gerd Hoffmann wrote:Patch #5 does just that. Almost. -watchdog continues to accept watchdog devices only. And '-watchdog ?' lists watchdog devices only. watchdog_list is gone, the qdev list is used instead. To identify the watchdog devices in the qdev device model list the capability bit is used. The patch description says so, doesn't it?Instead of checking the capability bit, why not look for a property with a type that's unique to the watch dog timer.
*There is no such property.*We are running in circles for months now. You are suggesting to look for a unique property. I point out that it simply doesn't work for certain devices due to lack of such a property. Repeat.
Can we stop that please? Do you suggest to create some unused dummy property to tag devices? thanks, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |