Re: [Qemu-devel] [PATCH] Fix and improve qint_from_int64_test

[Luiz Capitulino]

On Tue,  8 Sep 2009 11:53:37 +0200
Pierre Riteau <address@hidden> wrote:

> Use a long long integer constant to fix a compilation error (integer
> constant is too large for 'long' type).
> 
> Use a better value for testing, as -1 makes the test pass even if
> qi->value is of type uint32_t, float or double. This was suggested by
> Reimar Döffinger <address@hidden>.
> 
> Also, make the test fail when qi->value is of type double or float by
> casting qi->value to int64_t, to avoid value being promoted to the type
> of qi->value.
> 
> Signed-off-by: Pierre Riteau <address@hidden>

 Seems good to me.

 Acked-by: Luiz Capitulino <address@hidden>