Re: [Qemu-devel] [PATCH 01/14] i386: add private_features

[Alexander Graf]

On 09.09.2009, at 17:41, 武田 俊也 wrote:

> This patch is to add private_features to i386.
> It is like cpuid_ext*_features, but is used for any features
> not defined in CPUID.
>
> And "a20mask" feature is defined in private_features.
> It is for a20 adrdress mask of PC-98 family.

Due to the lack of a 00/14 conver letter, I'll just reply here.

Great job! Most of the code looks rather isolated, so I don't see any  
problem with including it in qemu. I gave you inline comments on the  
code where I see problems, as it collides with existing code.

In general having pc98 support could prove really useful, as there are  
few pc98 emulators around.

As for new files, please post them as patches as well. Since you're  
already using git, I'd recommend to look at "git format-patch", which  
creates really nice patches if you have committed things properly into  
the git tree before.

Anthony, please comment on this series as well, since you're the de- 
facto maintainer of x86 now I guess :-).

Alex