Re: [Qemu-devel] [PATCH 3/3] Enable migration without shared storage from the monitor

[Pierre Riteau]

On 10 sept. 2009, at 12:23, address@hidden wrote:

> This patch adds the option to activate non-shared storage migration  
> from the
> monitor.
> The migration command is as follows:
> (qemu) migrate -d tcp:0:4444 # for ordinary live migration
> (qemu) migrate -d blk tcp:0:4444 # for live migration with complete  
> storage copy
> (qemu) migrate -d blk inc tcp:0:4444 # for live migration with  
> incremental storage copy, storage is cow based.
>
> diff --git a/monitor.c b/monitor.c
> index 8d5165c..c8a6228 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -37,6 +37,7 @@
> #include "readline.h"
> #include "console.h"
> #include "block.h"
> +#include "block-migration.h"
> #include "audio/audio.h"
> #include "disas.h"
> #include "balloon.h"
> @@ -2507,6 +2508,24 @@ static void monitor_handle_command(Monitor  
> *mon, const char *cmdline)
>                         goto add_str;
>                     }
>                 }
> +
> +               if (*typestr == '!') {
> +                   char flag[4];
> +                   char * cmd_flag;
> +                   typestr++;
> +                    memcpy(flag, typestr, 3);
> +                   typestr += 3;
> +                   flag[4] = '\0';


You still have a buffer overflow here.

--
Pierre Riteau -- http://perso.univ-rennes1.fr/pierre.riteau/