qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create g


From: malc
Subject: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function
Date: Thu, 10 Sep 2009 21:02:01 +0400 (MSD)

On Thu, 10 Sep 2009, Juan Quintela wrote:

> malc <address@hidden> wrote:
> > On Thu, 10 Sep 2009, Juan Quintela wrote:
> >
> >> malc <address@hidden> wrote:
> >> > On Thu, 10 Sep 2009, Juan Quintela wrote:
> >> >
> >> > Point being?
> >> >
> >> > [..snip..]
> >> 
> >> See next patch.  We need to put the variable in one struct, we don't
> >> want to change everything to read the variable from the struct.
> >
> > So put the in the _pre vmstate callback (or whatever it's called).
> >
> >> 
> >> And at some point code, timer code have to move to qemu-timer.c code,
> >> not in vl.c.
> >
> > So?
> 
> What is the problem with this approach?

My problem with this patch is that it is completely pointless, touches
a gob of places and the fact that you apparently never seen what a
function call entails on PPC64 (any ABI).

[..snip..]

> My goal is having less global variables/state not more.  And your point
> to have it as it is today?

Yes, if it aint broke don't fix it.

-- 
mailto:address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]