Re: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function

[malc]

On Thu, 10 Sep 2009, Anthony Liguori wrote:

> malc wrote:
> > My problem with this patch is that it is completely pointless, touches
> > a gob of places and the fact that you apparently never seen what a
> > function call entails on PPC64 (any ABI).
> >   
> 
> But there is nothing to suggest this variable is every in the fast path 
> so any overhead argument is unfounded.
> 
> More importantly, using a function to access this variable gives us the
> ability to change how the behavior is implemented without touching a gob of
> places.
>

Untill such an ability is needed, the patch adds nothing, oh no it does
wonderful little global-replace gems like:

-        usb_frame_time = ticks_per_sec;
-        usb_bit_time = muldiv64(1, ticks_per_sec, USB_HZ/1000);
+        usb_frame_time = get_ticks_per_sec();
+        usb_bit_time = muldiv64(1, get_ticks_per_sec(), USB_HZ/1000);

> This is refactoring 101 and unless there is some concrete objection, I don't
> see what's wrong with it.

Once again, it adds nothing.

-- 
mailto:address@hidden