[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/12] cpuid: fix comments
From: |
Andre Przywara |
Subject: |
[Qemu-devel] [PATCH 04/12] cpuid: fix comments |
Date: |
Fri, 11 Sep 2009 00:20:49 +0200 |
Some comments regarding CPUID features were not up-to-date.
- Nested SVM is supported in qemu-kvm, but not in upstream qemu (yet).
- We support syscall/sysenter emulation in KVM now, so the comment
explaining the vendor string issue can be more relaxed.
Signed-off-by: Andre Przywara <address@hidden>
---
target-i386/cpuid.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 9ed9fb2..7b69ff4 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -610,10 +610,12 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index,
uint32_t count,
*edx = env->cpuid_vendor2;
*ecx = env->cpuid_vendor3;
- /* sysenter isn't supported on compatibility mode on AMD. and syscall
- * isn't supported in compatibility mode on Intel. so advertise the
- * actuall cpu, and say goodbye to migration between different vendors
- * is you use compatibility mode. */
+ /* sysenter isn't supported on compatibility mode on AMD, syscall
+ * isn't supported in compatibility mode on Intel.
+ * Normally we advertise the actual cpu vendor, but you can override
+ * this if you want to use KVM's sysenter/syscall emulation
+ * in compatibility mode and when doing cross vendor migration
+ */
if (kvm_enabled() && !env->cpuid_vendor_override)
host_cpuid(0, 0, NULL, ebx, ecx, edx);
break;
@@ -720,7 +722,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index,
uint32_t count,
}
if (kvm_enabled()) {
- /* Nested SVM not yet supported in KVM */
+ /* Nested SVM not yet supported in upstream QEMU */
*ecx &= ~CPUID_EXT3_SVM;
} else {
/* AMD 3DNow! is not supported in QEMU */
--
1.6.1.3
- [Qemu-devel] [PATCH 0/12] cpuid: cleanup and some enhancements, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 02/12] cpuid: fix over-long lines, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 01/12] cpuid: move CPUID functions into separate file, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 03/12] cpuid: replace magic number with named constant, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 05/12] cpuid: moved host_cpuid function and remove prototype, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 04/12] cpuid: fix comments,
Andre Przywara <=
- [Qemu-devel] [PATCH 09/12] cpuid: simplify CPUID flag search function, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 06/12] cpuid: add missing CPUID feature flag names, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 11/12] cpuid: add TCG feature bit trimming, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 08/12] cpuid: remove unnecessary kvm_trim function, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 12/12] cpuid: decrease L2 cache for Intel and add comments, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 10/12] cpuid: propagate further CPUID leafs when -cpu host, Andre Przywara, 2009/09/10
- [Qemu-devel] [PATCH 07/12] cpuid: list all known x86 CPUID feature flags, Andre Przywara, 2009/09/10