[Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function

[Juan Quintela]

malc <address@hidden> wrote:
> On Thu, 10 Sep 2009, Anthony Liguori wrote:
>
>> malc wrote:
>> > On Thu, 10 Sep 2009, Anthony Liguori wrote:
>> > 
>> >   
>> > > malc wrote:
>> > >     
>> > > > My problem with this patch is that it is completely pointless, touches
>> > > > a gob of places and the fact that you apparently never seen what a
>> > > > function call entails on PPC64 (any ABI).
>> > > >         
>> > > But there is nothing to suggest this variable is every in the fast path 
>> > > so
>> > > any overhead argument is unfounded.
>> > > 
>> > > More importantly, using a function to access this variable gives us the
>> > > ability to change how the behavior is implemented without touching a gob
>> > > of
>> > > places.
>> > > 
>> > >     
>> > 
>> > Untill such an ability is needed, the patch adds nothing,
>> 
>> Except that it eliminates the possibility of misusing the interface and
>> setting it somewhere it shouldn't be.
>> 
>> It makes the code more defensive because you cannot accidentally use it like
>> it's a local variable.  The key bit of the patch is:
>> 
>> -int64_t ticks_per_sec;
>> +static int64_t ticks_per_sec;
>> 
>> 
>> That is *always* a worthwhile change to make.  We need more patches like 
>> this.
>> 
>
> And generalizations are always true.

So?

> Anyhow, i'm explicitly against the
> patch, so first obtain the express acknowledgment from the leaders,
> otherwise i'll revert it should it go in.

Now playing the commit access card.

At this point I retire for the discussion, as clearly I am not one of
the leaders to revert your revert back.

Later, Juan.