qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/19] Never overwrite a QemuOpt


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 07/19] Never overwrite a QemuOpt
Date: Fri, 11 Sep 2009 09:51:00 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3

On 09/10/09 17:18, Mark McLoughlin wrote:
Rather than overwriting a QemuOpt, just add a new one to the tail and
always do a reverse search for parameters to preserve the same
behaviour. We use this order so that foreach() iterates over the opts
in their original order.

I think we should simply add a flag to QemuOptsDesc saying 'this can have multiple instances' instead of doing these reverse search tricks to maintain backward compatibility.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]