[Qemu-devel] Re: [PATCH 12/12] qdev/isa: convert real time clock

[Jan Kiszka]

Gerd Hoffmann wrote:
>> --- a/hw/mc146818rtc.c
>> +++ b/hw/mc146818rtc.c
>> @@ -63,10 +63,11 @@
>>   #define REG_C_AF   0x20
>>
>>   struct RTCState {
>> +    ISADevice dev;
>>       uint8_t cmos_data[128];
>>       uint8_t cmos_index;
>>       struct tm current_tm;
>> -    int base_year;
>> +    uint32_t base_year;
> 
> Self-NACK.  This sign change breaks some math and makes my VMs
> time-travel to 2005 ...
> 

I thought you retracted this patch, but now I find it in master. Is
there fix in the queue?

To err is human, and the more patches are committed, the more errors can
happen. Still, my impression is that the current rate could be lower.
Gerd, maybe you should have CC'ed Anthony for the NACK.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux